Skip to content

feat: refactor and add sanitizeUtf8 processor #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
SkArchon wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: refactor and add sanitizeUtf8 processor #2485

SkArchon wants to merge 3 commits into from

Conversation

@SkArchon
Copy link
Contributor

@SkArchon SkArchon commented Feb 2, 2026

@coderabbitai summary

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@github-actions github-actions bot added the router label Feb 2, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026 •
edited
Loading

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-0dd0899b760f32357bd9da0fd2f3b5f8a532de46-nonroot

@codecov
Copy link

codecov bot commented Feb 2, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.38462% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.87%. Comparing base (b188b46) to head (8da4582).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...outer/pkg/trace/attributeprocessor/sanitizeutf8.go 86.66% 1 Missing and 1 partial ⚠️
router/pkg/trace/attributeprocessor/attributes.go 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            main    #2485       +/-   ##
==========================================
+ Coverage   1.50%   53.87%   +52.36%     
==========================================
  Files        292      215       -77     
  Lines      46816    23319    -23497     
  Branches     431        0      -431     
==========================================
+ Hits         703    12562    +11859     
+ Misses     45830     9511    -36319     
- Partials     283     1246      +963
Files with missing lines Coverage Δ
router/core/router.go 69.39% <100.00%> (ø)
router/pkg/config/config.go 20.77% <ø> (ø)
router/pkg/trace/attributeprocessor/redact.go 100.00% <100.00%> (ø)
router/pkg/trace/config.go 75.00% <100.00%> (ø)
router/pkg/trace/meter.go 34.74% <100.00%> (ø)
router/pkg/trace/attributeprocessor/attributes.go 92.85% <92.85%> (ø)
...outer/pkg/trace/attributeprocessor/sanitizeutf8.go 86.66% <86.66%> (ø)

... and 500 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Noroth Noroth Awaiting requested review from Noroth Noroth will be requested when the pull request is marked ready for review Noroth is a code owner

@devsergiy devsergiy Awaiting requested review from devsergiy devsergiy will be requested when the pull request is marked ready for review devsergiy is a code owner

@StarpTech StarpTech Awaiting requested review from StarpTech StarpTech will be requested when the pull request is marked ready for review StarpTech is a code owner

@jensneuse jensneuse Awaiting requested review from jensneuse jensneuse will be requested when the pull request is marked ready for review jensneuse is a code owner

@endigma endigma Awaiting requested review from endigma endigma will be requested when the pull request is marked ready for review endigma is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SkArchon